Anton Hägerstrand

Any feedback would be very welcome. Most likely, there is some edge case that I've missed.

@imranazad The plugin installation from file works fine for me on osx, running ES 2.0.0: ``` ❯ bin/plugin install "file:///Users/anton/Desktop/es-plugin-test/elasticsearch-analysis-combo-2.0.0-SNAPSHOT.zip" -> Installing from file:/Users/anton/Desktop/es-plugin-test/elasticsearch-analysis-combo-2.0.0-SNAPSHOT.zip... Plugins directory [/Users/anton/Desktop/es-plugin-test/elasticsearch-2.0.0/plugins] does not exist....

@ofavre Are you still a maintainer of this repo? If so, could you leave a comment regarding this PR? If not, could you point me in the right direction? Any...

@rogr This plugin is what ES calls a "Java Plugin", which means (among other things) that the zip-file to be installed needs to be built to contain .jar files with...

Thanks for the approval! I do however think that it would be good to prove this performance improvement in luceneutil before merging, to make the benchmark more easily reproducible than...

I spent some time "proving" this is luceneutil - [luceneutil/pull/257](https://github.com/mikemccand/luceneutil/pull/257) adds a reproduction - if run with `wikimediumall`, `optimize = True` for indexing and `commitPoint = 'single'`. The reason that...

> Would we be subject to the same issue if/when 3+ different implementations of `DocIdSetIterator` get used in `IntersectVisitor#visit`? Yes. Your question makes me think that maybe we should not...

@jpountz I had a quick look at the code, and it seems to me like there are, with this PR, only two implementations used for the DISI used for the...

> That said, I wonder if this change is legal: `DocIdSetIterator` must return doc IDs in order, but it looks like it wouldn't always be the case with your change?...

I've changed the readInts16/34 methods to now use the `IntsRef` instead - I kind of like how it turned out, but the downside is that we will have to add...