Anton Grbin

Conformance test: JSON parsing of unknown enum string values

5

# Motivation Different clients yield different results when JSON parsing unknown enum **string** values: 1) java, cpp will ignore the unknown enum string value when ignoreUnknown is set 2) python,...

The testing message is defined as follows: ```proto syntax = "proto2"; message MessageWithEnum { enum EnumType { FOO = 0; BAR = 1; } optional EnumType value = 1; }...

# Motivation See https://github.com/streem/pbandk/issues/235#issue-1416975668 Note that all unit tests in this PR are currently passing.

# Motivation As of today I don't intend to merge this to master. I am using this only to test the current behavior of various implementations. Related discussion with a...

# Motivation This PR fixes failing conformance tests for python with name `IgnoreUnknownEnumStringValue`. The JSON parsing spec was discussed in https://github.com/protocolbuffers/protobuf/issues/7392. Recent equivalent changes for other languages: * Swift: https://github.com/apple/swift-protobuf/pull/1345...

This test was suggested by @jskeet in the related issue: https://github.com/protocolbuffers/protobuf/issues/7392#issuecomment-1884666885 I am not confident that the failure lists are comprehensive (I only run a few tests locally) -- will...

[7392] fix conformance test in PHP JSON parser

4

# Motivation This PR fixes failing JSON conformance tests for php with name `IgnoreUnknownEnumStringValue*`. The JSON parsing spec was discussed in https://github.com/protocolbuffers/protobuf/issues/7392. Recent similar changes in other languages: - Python:...

[7392] [cpp] Remove dead code path for map key of type enum in JSON parsing

5

# Changes Remove dead code path -- we don't allow enums to be map keys ([proto2 spec](https://protobuf.dev/programming-guides/proto2/#maps), [proto3 spec](https://protobuf.dev/programming-guides/proto3/#maps)). In other words the case block `case FieldDescriptor::TYPE_ENUM` is dead code....

[7392] [cpp] Fix IgnoreUnknownEnumStringValueInMap conformance tests

6

## Motivation This PR fixes failing JSON conformance tests for cpp with name `IgnoreUnknownEnumStringValueInMap`. Specifically, for the following input of type [TestMapOfEnums](https://github.com/protocolbuffers/protobuf/blob/2f3242c576504459621fd7d78bbccf39bfaa49c5/src/google/protobuf/util/json_format.proto#L119): ```json { "enum_map": { "key1": "PROTOCOL", "key2": "UNKNOWN_ENUM_STRING_VALUE",...