Anton Kolesnyk comments

Results 79 comments of


                                            Anton Kolesnyk

Multiblock and append blobs implementation

Thank you so much @szymsta! It is really high quality PR. We are looking at it, and it may take us up some time as we'll review mostly the API...

Rename live test matrix leg name to be more generic/general purpose rather than "with_iot_samples"

I'd drop "with_samples" - one test may chose to do live testing via samples, other one may not. The goal is to live test, so if some sample is not...

Improve build flag testing

I propose us to have: 1. `VERIFY_CMAKE` compile flag. We don't document it, and we wet it to on for all our CI/CD build configurations (by supplying `-DVERIFY_CMAKE=ON`among with the...

Incorrect Calculation _az_http_policy_logging_append_http_request_msg()

Thank you @ericwol-msft, this is a bug, we should fix it. And thank you for the detailed info, you basically wrote the fix as well! @ahsonkhan, you are right, there...

[FEATURE REQ] Investigate Playback and record system

I think we should have live tests + unit tests, and NOT have response recorder. For the response recorder, we need to filter out secrets from the recorded responses, and...

We need mock PAL/HTTP client layers for testing

This is no longer needed, because the reason we had to use this is now covered by mock framework. It maybe can have some benefits sometimes, but for now it...

We need mock PAL/HTTP client layers for testing

Let's reconsider. When a mock test fails, it is hard to repro and debug on a local windows machine.

We need mock PAL/HTTP client layers for testing

@ahsonkhan , this is what we've run into

We need mock PAL/HTTP client layers for testing

Based on offline conversations, we can move this one for the next sprint.

Running Live Tests

To tell the CI run live tests against this PR, I think you need to put this comment: `/azp run go - azblob`