Salvatore Sanfilippo

Results 165 comments of Salvatore Sanfilippo

Hello! If you tested with the latest commit of Linenoise (very likely), it is going to be very hard to fix, because it uses really the bare minimum of pure...

Any hint about this PR before reading the code? Thanks.

Hey folks, thanks for your efforts. What do you think the best support is so far among the ones contributed? I would like to spend some time to review.

Ok I took some time to read both the implementations. They are both nice in different ways. But my feeling is that this implementation is too complex for the linenoise...

Hello, I hope to continue the development after the end of October, when Redis 4.0 will be released. Sorry for the delay, I was not able to have the free...

P.S. It's worth to note that in the meantime, Redis got a modules API... and I want to extend the module API in order to support a Cluster API to...

This change looks great! I'll merge it in the next days. Thanks.

Hello, thanks for your contrib, looks interesting, I'll review the next time I get some free time. This fork is still maintained but with time limits, and still targets codebase...

p.s. it would be nice if @MalcolmRobb will do the same and modify the README to write that the code originates from this project (not for lack of credits, in...

Thanks, this is something I wanted to do soon or later, so very happy to see this code. I'll review later today hopefully. I moved in the new house and...