Salvatore Sanfilippo

icon indicating a website link http://invece.org icon indicating an email [email protected]

icon company Redis Labs icon location Catania, Sicily, Italy icon location Computer programmer based in Sicily, Italy. I mostly write OSS software. Born 1977. Not a puritan.

Results 165 comments of Salvatore Sanfilippo

[Vector sets] Endianess fix and speedup of data loading

> No comments Thank you for reviewing :)

[Vector sets] Replace manual popcount with __builtin_popcountll for binary vector distance

Thank you, @fcostaoliveira! I'm all for that, but for maximum portability I would use the macro that we have indeed. I also wonder if we should compile hnsw.c with different...

[Vector sets] Replace manual popcount with __builtin_popcountll for binary vector distance

Hey! Thank you for all your work. I suggest creating hnsw_popcount.h file that defines hnsw_popcount() with the exact same logic, like we do in Redis in other places, this way...

[Vector sets] Replace manual popcount with __builtin_popcountll for binary vector distance

Thank you @fcostaoliveira, I suggested a different approach, but it should be very simple to get there: the hnsw function for binary distance belongs in hnsw.c, the only thing that...

[Vector sets] Replace manual popcount with __builtin_popcountll for binary vector distance

@sundb ok, you mean: if we move the check for popcount in the function doing popcount, we burn the speed gain that we got. This makes sense. Then, I would...

WIP: Add support to fallback to all results of getaddrinfo() (ipv6/ ipv4 dual-stack, DNS-RR)

Thanks @chr4, I'll evaluate this change with Redis 6 as target, with the possibility to back port to Redis 5. Right now I don't have the full picture to really...

Issue with Partial Resynchronization(PSYNC) feature supported by Redis v4

Sorry for the brief reply, I'm in vacation. I wanted just to tell you that in the course of Redis 4 we fixed tens of bugs related to your issues,...

Sentinel: Long delay before detecting master is subjectively down.

Hello, I noticed this issue and problem only now, I'm checking if all this still applies to modern Redis.

Sentinel: Long delay before detecting master is subjectively down.

Problem acknowledged. I think the best fix could be just to let the function send the three types of messages independently, without sending just a single message per iteration. I...

Sentinel: Long delay before detecting master is subjectively down.

I'm not sure if @soloestoy also focuses on Sentinel internals, but if so I would love to have his opinion on the above patch. Thanks!