Anthony Oleinik

I can get behind this. I considered making this change multiple times. The reason why I didn't was because I wanted everything in widgets/magnifier.dart to be text-editing agnostic, since it...

On board! @tgucio do you mind cleaning up those nits? Definitely my mess leftover from my PR, sorry about that.

This whole comment assumes that there's no way to drag the right handle without it already being in view. If that's a wrong assumption, then disregard :). I wonder if...

> @antholeole thank you for your comments! Why does`bringIntoView` exist there originally? actually, I can remove the line and it passed all tests in my local... @takassh It was an...

@takassh So, just to be clear, when you remove the line that I mentioned, https://github.com/flutter/flutter/issues/105821 still happens? I removed that line and this is the behavior I get: https://user-images.githubusercontent.com/48811365/175373354-d8f78799-61bf-42ee-977a-df2540ea39a1.mov It...

Looks like you're right! The further calls are needed on platforms not iOS / macOS. thanks for this!

@justinmc what about changing ‘SelectionChangedCause.drag’ to something like SelectionChangedCause.dragLeftHandle and SelectionChangedCause.dragRightHandle? Just a thought!

@takassh I'll be taking over the review on this one :) sorry about the slowness, I'll get this reviewed asap. It looks almost done though, good job!

Something like this: ```diff diff --git a/packages/flutter/lib/src/widgets/text_selection.dart b/packages/flutter/lib/src/widgets/text_selection.dart index 30f96187ba..e59d176fd9 100644 --- a/packages/flutter/lib/src/widgets/text_selection.dart +++ b/packages/flutter/lib/src/widgets/text_selection.dart @@ -2286,6 +2286,11 @@ class ClipboardStatusNotifier extends ValueNotifier with Widget } } +enum TextSelectionHandleSide {...

EDIT: Sorry, I accidently posted this comment on the wrong PR! My fault....