anson1014
anson1014
> The CI is all failing on the mtr `main.long_unique_bugs` which definitely seems related to the changes in this PR: > > > > ``` > > main.long_unique_bugs 'innodb' w5...
Couldn't find too much online regarding the "an-trap" directive. If there's not much documentation on why it is there and there is no functional difference between the output I think...
Good catch, the fix makes sense and the accompanying test seems to accurately depict the scenario you are describing in your description.
In the description of [MDEV-32777](https://jira.mariadb.org/browse/MDEV-32777), I can see very clearly the times listed to run the attached DDL script in macOS and how it is much slower than other platforms....
Thanks for that, I see now where you mentioned the results on the Jira. Looks good!
Minor nits: - some unnecessary whitespace - consider removing the brackets for your single line if statements in order to adhere to: https://github.com/MariaDB/server/blob/11.5/CODING_STANDARDS.md Otherwise, the logic and the motivation for...
Hi @LinuxJedi, I've addressed the comments you raised and tried to fix the stylistic differences. A re-review would be much appreciated!
Good idea @dr-m, I've rebased and here's an example log of before and after. ``` ### BEFORE ### main.blackhole w3 [ fail ] Found warnings/errors in server log file! Test...
For each file, I've added the violation that UBSAN reports prior to my changes. These errors are not reported by UBSAN after my changes.
Similar to #3503 which is also still pending review.