Anna McPhee
Anna McPhee
Had a user request from the iOS App Store reviews for this.
Request for CPT support in the iOS app at 1992856-zen
I have P2'd this in pejTkB-1AX-p2
> I like where this is heading. Great work @annacmc ! Everything looks great! I think we could try to limit the scope as is and ship it soon 👍...
@adamwoodnz I've tried to work in with your recent storybook restructuring and get all of the stories into their relevant legend directories. But let me know if I've misunderstood anything...
Thanks so much everyone for your feedback. I have made some of the suggested changes, and am going to iterate on @chihsuan and @adamwoodnz remaining suggested in my next PR...
> In my testing, the `.bar-chart` container is expanded (`420px`) to the specified height (`400px`) plus the legend height (`20px`), but the chart section remains the original height (`380px`) of...
Thanks for your thoughts Jasper. I am still trying to wrap my head around exactly what we want. But I think it makes the most semantic sense to me that...
> I would expect something like the following, basically what bar chart is doing before this PR. This is essentially what it's already doing without this PR. I'm trying to...
Thanks that would be amazing if you have some space to look next week (either at this or I do have ~3 components I am attempting to add in this...