Aniruddha Bhattacharjee

Results 33 comments of Aniruddha Bhattacharjee

I would go for a config option, something like `split-singleline-comments`, because as already mentioned in the thread there are complications when it comes to splitting in-line comments and I would...

@felix-hilden Make ssense then to make this a default behavior, the inline scenario needs to be specified in the docs. I also prefer the 2nd one, but I believe that...

As stated by @jvahue, > and for situations like > > ``` > x = 1 > z = x + 2 # a long comment blah blah blah ......

Hey @danielgafni and @matteoettam09, this issue seems relevant to this earlier one: https://github.com/PyCQA/isort/issues/1790, I don't exactly know if this is applicable here but sharing if this gives any insight. In...

> I can only share my observations... the import line that was causing the issue was an import from the "scripts" directory. Can you provide the exact error? Like is...

in addition to nested redundant imports, *isort* also doesn't remove duplicated imports if they are not in the same import block. For example: ``` import a import b print("hello all")...

@razinc the config flags are defined here: https://github.com/PyCQA/isort/blob/5f6bc03f2000aec3e70b65324d940ce6f1395d25/isort/settings.py#L115 You can get the parsed file contents here: https://github.com/PyCQA/isort/blob/develop/isort/parse.py Just off the top of my head, I guess you will need to...

@razinc happy to help :) Contributing guidelines are here: https://github.com/PyCQA/isort/blob/develop/docs/contributing/1.-contributing-guide.md. You can write tests and build/run the modified code to see if it has the intended behavior or not. Does...

@razinc everything looks cool. I personally use the docker environment to build/run *isort* but as you haven't really changed anything yet, it should be fine.