Hong Chulju
Hong Chulju
@rampatra Could you review this change? I appreciate it if you could. Thank you.
I'm interested in digging into this.
@dhh Do you intent to allow this url form only? (`posts(.:format(+:variant))`) http://example.com/posts.html+partial (1) Not http://example.com/posts+partial (2) (`posts(.:format|+:variant)(.:format|+:variant)`) http://example.com/posts+partial.html (3) (`posts(+:variant(.:format))`)
I've tried to implement like below: ``` diff diff --git a/actionpack/lib/action_dispatch/http/mime_negotiation.rb b/actionpack/lib/action_dispatch/http/mime_negotiation.rb index 53a98c5..886ce3a 100644 --- a/actionpack/lib/action_dispatch/http/mime_negotiation.rb +++ b/actionpack/lib/action_dispatch/http/mime_negotiation.rb @@ -10,8 +10,6 @@ module ActionDispatch self.ignore_accept_header = false end -...
Okay. I'm going to open a new pull request.
Maybe will solve w/ #5
Then, below is correct behavior? ``` ruby try! { 1 } # => Success(1) try! { Success(1) } # => Success(1) try! { Failure(1) } # => Failure(1) ```