Andre Fredette

Results 41 comments of Andre Fredette

I don't have a problem extending the ACLAddEntity API. This API is fairly new, so it's probably not widely used. I currently have a draft PR open on ovn-kubernetes that...

I've looked into this a bit this morning. I was originally thinking the name field could be used effectively as an index as is done for some other objects. However,...

> @anfredette @hzhou8 name field being non-unique may be there for a good reason - ACLs can be grouped for logging purposes, e.g., we want to log events after some...

@hzhou8, @vgozer, I updated the ACL API based on this discussion. Well, I actually took it a little farther and used UUIDs for both entity and ACL. I've reviewed all...

I updated the description based on a discussion with @hzhou8 on the desired behavior.

@astoycos, I was attempting to try this branch out, and have a couple of questions. Do you expect this to still work with https://github.com/astoycos/tcxtest? I tried and I get the...

These changes make your tcxtest work again: https://github.com/astoycos/tcxtest/pull/1

Is there an api to get the list of tcx programs currently attached to an interface/direction (including their order)?

> I would like to > > * [ ] Add support for the replace API > * [ ] Add more testing for replace API + the rest of...

@tamird for some reason, I can't respond directly to your latest comments. So, I'll respond by adding my own comments on the code you reference.