Jonas Metzener comments

Results 50 comments of


                                            Jonas Metzener

Use viewBox instead of width, height, x and y

If you set a correct `viewBox` you don't have to set `width` and `height` too, since it will take the initial size from the `viewBox`. By the way, very nice...

fix: use legacy syntax for decorators

This also drops support for node 6 since it's EOL is 2019-04-30 and `ember-decorators` v6+ doesn't support it

fix: use legacy syntax for decorators

@offirgolan I don't really see the reason for the failing tests.. Maybe cleaning the Travis CI cache would help?

fix: use legacy syntax for decorators

Sadly I just learned that this doesn't really work the way I intended it.. The routes [`setup`](https://github.com/emberjs/ember.js/blob/v3.14.1/packages/%40ember/-internals/routing/lib/system/route.ts#L898) hook which initializes the QPs values uses a computed property [`_qp`](https://github.com/emberjs/ember.js/blob/v3.14.1/packages/%40ember/-internals/routing/lib/system/route.ts#L2266) which uses...

Inaccurate Coverage Reported

I'm experiencing the same issue.. It reports stuff like: ```javascript import moment from 'moment' // Branches [[2, 1], [8, 1], [10, 1], [12, 1]] missed. ``` Which is absolutely wrong

fix(helper): check if helper is destroyed before adding the observer

I'll try. It's a really weird edge case that occured in tests of a project I'm working on.

Add assigned_users to workflow, case and task

Makes sense IMO :+1: Would it make sense to also define `address_groups` and `control_groups` on the workflow and transfer them on to the case to be consistent with work items?

Integer values should be big integers

`{"errors":[{"message":"Int cannot represent non 32-bit signed integer value: 13120310230123"}]}`

Submitting the form refreshes the page

I once encountered this with a nested `` which would be invalid HTML. Is this the case for you?

Submitting the form refreshes the page

Can you provide a twiddle (based on https://ember-twiddle.com/3691a8576c35ff149bfc26a564ec5437) reproducing your use case?