Andy Grundman
Andy Grundman
Audio-Scan could probably support parsing the additional mp4 box types used by m4b files and provide them as part of the tag data. I'd be ok adding this as long...
Glad you got it to work, the buffer can be tricky. Uncommenting `#define AUDIO_SCAN_DEBUG` at the top of include/common.h can be helpful for debugging buffer-related issues. If you need more...
You need 4 bytes per pixel just to load in an image, and that's where the 210MB comes from. This doesn't count any additional memory libpng needs, etc. This isn't...
Good call, and the API looks simple enough and supports some nice memory-friendly features like pre-scaling. I’ll take a look at it.
Yes, you're right, it should be benchmarked against similar tools. I wrote Image::Scale back in 2010 and at the time GD/IM were the two big ones I was aware of....
I think the build issues might be fixed now for Win/Mac/Linux. I wanted to mention a new error I ran into thanks to the `-fanalyzer` mode on one of the...
I've removed the test suite in my patch for a few reasons: * couldn't get it to build on win64, some MSVC/cmake/appveyor conflict, I dunno. * Probably weird to have...
Apologies for the delay, I am not entirely sure if marking everything resolved lets you know or if I am supposed to use "re-request review".
Sounds good. I know large patches are a pain and I sometimes get a bit carried away, so I appreciate the review.
> @andygrundman can you rebase your branch on the latest master, switch back to the upstream moonlight-common-c submodule, and split the audio changes out of this PR? > > Let's...