Andy Balholm

Results 55 comments of Andy Balholm

I've added bz2 support in my fork (github.com/andybalholm/sift).

Do you close the brotli.Writer after you're done writing to it?

I run it under Go 1.18 all the time now. But there's no reason I can think of that we should mark it as *requiring* Go 1.18, unless we actually...

Adding an error return to NewWriterLevel is an API change. Doing that would require releasing a new major version of the package. Instead, we should replace levels less than BestSpeed...

Yes, that's a fine API design. But it's not worth a breaking change.

The issue only affects the one-shot decompression API, which is not exposed by this package.

Yes, the code was translated with c2go. It was definitely not a fully automatic process. The license shouldn't be a big issue, since nearly everything that isn't a direct translation...

No, Cascadia has no concept of scope at all. A selector either matches an element or it doesn't. There is no provision for matching an element relative to a given...

Yes, that's what it would be. But Cascadia selectors don't know where they start. The basic interface of the Cascadia package is Matcher: ```go type Matcher interface { Match(n *html.Node)...

No, because those are implemented as wrappers around Match. Almost everything in Cascadia is built around the Match interface. Support for scope would require such an extensive rewrite that the...