Andrew Bennett

Results 11 comments of Andrew Bennett

> Is anything else needed? hey @sashashura apologies for the delayed response, unfortunately the change appears to have broken the CI build causing two of our checks to fail. I...

> I get the error even if I don't touch permissions at all. Only modified [the `if` condition](https://github.com/sashashura/simorgh/actions/runs/3245163838/workflow#L53) to skip Chromatic UI in my fork's default branch - that it,...

Readme is still wrong and needs updating: https://github.com/bbc/simorgh/blob/latest/src/app/hooks/useToggle/README.md

Thanks so much for putting together this detailed issue @jroebu14, I've read through it and taken a look at the migration guide myself as well, here's what I've taken away...

Assuming the backwards compatability package becomes available we will be at no risk for a security perspective, we will just be using an increasingly outdated API harming our maintainability. I...

This looks great, it solves the part of my suggestion I was most worried about, generating a hash for Simogh data on each page load and adding it to the...

Might be nice to discuss this again, most of the data fetching/error handling is centralised in `fetchPageData` to my mind. What more does having a standardised getInitialData give us?

Reading this, it looks like this also improves clientside rendering performance, not just pre-fetching serverside rendered pages in the viewport.

We'd need to consider the data cost of downloading pages in the background for users while we continue to serverside render. If we enabled this on front pages on mobile...

This component is known to be complex and messy. We move the logic behind the BFF and reduce our bundlesize and hydrate a slimmed own analytics component from the BFF...