Andrew Peters
Andrew Peters
It looks like the main API file could be cleaned up a bit, as a lot of code is repeated. Let me know if you're OK with me doing this,...
I understand that some of Tensorflow's util files had to be modified for this to work; however, I believe this API could be made more elegant if there were a...
**Is your feature request related to a problem? Please describe.** - Prisma's current API for hooks (esp. at model level) is lacking. - `.$extends` requires explicit method wrapping, and doesn't...
## Draft until underlying PR is merged
There seems to be some inconsistencies with how data is serialized and deserialized in some of the Metamask keyring libraries. For the Trezor keyring: - `this.paths` is included in serialization,...
**Issues:** 1. `LedgerBridgeKeyring` can accidentally be initialised twice on the same client, resulting in silent failures (e.g. messages be either duplicated or resolved prematurely/incorrectly). 2. Now that set-up logic is...
If someone `init`'s the keyring twice, or calls `updateTransportMethod` twice quickly while the iframe is loading then you could run into situations where this `if` block runs (see [here](https://github.com/MetaMask/eth-ledger-bridge-keyring/blob/main/index.js#L458)) but...
Some improvements can be made to the serializing and deserializing of data: - `this.hdk` can/should be serialised and deserialised - Only the `publicKey` and `chainCode` needs to serialised/deserialised - Setting...
### Ethers Version 6.13.1 ### Describe the Problem * Some networks do not support `eth_newFilter`, this issue was addressed here: * #4162 * However, some networks support the method, but...
**❗ This issue is a work in progress, I'll do a bit more research into the implementation details.** **Motivation:** * Prefixed IDs allow for the identification of the model with...