andrewimcclement

Results 29 comments of andrewimcclement

I guess we could consider copying the [UseCulture(...)] attribute from https://github.com/xunit/samples.xunit/blob/main/UseCulture/UseCultureAttribute.cs and using that (it isn't included as part of XUnit by default as per https://github.com/xunit/xunit/issues/290). I'm not really sure...

A minor note: these days, assuming the array comes typed as `IReadOnlyCollection/IReadOnlyList`, you can use `Has.Count`.

If we wanted to do this, we could possibly just mark [TestFixture] as [Obsolete] in NUnit, though doing that is less flexible than having a code analysis rule.

Presumably there is a suitable escape mechanism we can use when creating the XML in the first place?

Should the same analyser warn against use of Assume?

I am currently looking at this, though progress is slow (I haven't done anything with ASTs before).

Current working branch is https://github.com/andrewimcclement/nunit.analyzers/tree/aim/values-usage-analyzer, with relevant code to be found at https://github.com/andrewimcclement/nunit.analyzers/blob/aim/values-usage-analyzer/src/nunit.analyzers/ValuesUsage/ValuesUsageAnalyzer.cs. Not ready to create a pull request. Need to extract the type of the parameter as well...

If it is decided that this isn't a good idea, an alternative would be to provide a setting for the _default_ powershell path to use for scripts. (I'm assuming that...

Do you mean by editing the Run configuration template for PowerShell to point at the PSCore path? Or is there a more obvious setting somewhere? (I'm not entirely sure I...

Given that `Arity` has exactly the desired meaning, would it be better to provide a suitable summary comment for people unfamiliar with the term? Part of my concern is that...