Andrew Rosa

Results 33 comments of Andrew Rosa

My 2 cc: the `^:private` form also helps with learning. Explaining that `(fn [])` and `#()` are quite the same is one thing, but the lack of `(def-)` & friends...

Sorry to ping @danielberkompas, any thoughts on this PR? We would love to have theses :telemetry events as we're mass adopting OpenTelemetry at our company :)

@tsloughter this is the instrumentation we talked few weeks ago on EEF observability WG meeting. It's posted as draft for two reasons: * First, it depends in unreleased and WIP...

Hey @rewritten! I linked all Absinthe issues in the description of this issue here. The gist is, we need telemetry events for all kinds of helpers/middleware (async/batch), and they need...

Isn't this task better suited for https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/85? The concern is this become a pattern for all instrumentation libraries. Not sure how it's the vision for that, specially after the Instrumentation...

For the record: while a lot of this is experimental in the sense attributes, methods of propagation etc are WIP, a similar impl is in prod.

@bryannaegele I did a try locally and I was able to reduce the amount of changes so I say 👍

Are you working on this @ohpauleez? Some time ago I've take a look at those benchmarks and how they could be improved in general. In particular, I believe they are...

Hey @binaryseed, sorry as I don't have access to the code anymore. The problem arise from a scenario like that: * `app -> client_lib -> (optional) new_relic_agent ` * `app...

Something I've noticed during my tests, looks like Transaction traces are not working for "Other" transaction types. I've tried the same thing with Oban instrumentation (which I didn't published yet)...