Andrew Best

Results 11 comments of Andrew Best

Good spotting @flakey-bit. Fixing this would be reasonably straight-forward. I'll either get to it eventually, or someone can pick it up, I've labelled it a good first issue if someone...

I was thinking you would essentially have to replicate what MSBuild does - for any project, locate the directory.build.props file closest to it, and consider its values in applying the...

Yup, strong agree there. I know dotnet-affected uses MsBuild internally ([example](https://github.com/leonardochaia/dotnet-affected/blob/main/src/DotnetAffected.Core/Processor/AffectedProcessor.cs)), so it is very possible that that is a doable thing.

G'day @flakey-bit - sorry about the very late response here, I missed this issue 😞. I'll have a read this afternoon and get back to you.

Okay, so, a fun, but complex problem. One tool uses Cecil to rewrite a module at runtime, and then another uses cecil to try and read module types at runtime....

> Let me know if I can help out in any way with this 🙂 If you want to throw together a spike PR to help me understand your suggestion...

> I guess a consideration is that this effectively hides things from WrappedConventionResult. That might be fine, but some kind of "Skipped" outcome might be better? I don't think that...

@flakey-bit did you want to take a look at the PR I've pushed up to see if it will address your issue?

> The behaviour should be modified to throw an error if an account is not contributed such as when scoping is wrong when a user provides an AWS account. This...

Release Note: Fixes issue where `ProjectEdit` permission was inadvertantly required to create deployments.