Andreu Font-Ribera
Andreu Font-Ribera
I was running Picca on mocks and noticed several warnings in the output error files: ``` cat /global/cfs/cdirs/desi/users/font/test_mock_53/picca_on_qq/v9.0.53.100.100/desi-4.124-4-prod/baseline/logs/picca_delta_extraction_lya_fitted-18605671.err /global/common/software/desi/perlmutter/desiconda/20230111-2.1.0/conda/lib/python3.10/site-packages/iminuit/util.py:147: UserWarning: Assigned errors must be positive. Non-positive values are replaced by...
I just noticed a message of H0=100, what is at least confusing. I believe H0 is not used in picca_xcf, but if we use it we should use a more...
I just happened to see these while inspecting logging files... This is scary, and I think we should make the code crash!
I was looking at how Picca does the sub-sampling, and it looks like it assumes a zero variance for bins not measured. https://github.com/igmhub/picca/blob/02496df79e088332344e2f9322b681d71117ecbf/py/picca/utils.py#L56 I'm not sure this is used anywhere...
Once we are happy with the many ongoing PRs, we should address this confusing naming. We currently use forest.continuum to mean "continuum * mean flux*, but other continuum fitting codes...
In the DR16 analysis we would first read the deltas, and used (zmin,zmax) from the deltas and (rpmax,rpmin) to set the relevant redshift range for quasars. However, for some reason...
Following an email from Nico Busca, it would be interesting to modify the current calculation of the distortion matrix to account for the growth of the Lya fluctuations with redshift.
Following the instructions at NERSC, on a clean environment, I find this: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour...
The current README talks about fitter2 instead of talking about Vega, we should update this. Also, it doesn't explain how to use Picca in Jupyter notebooks at NERSC (setup kernel,...