Andres Rey
Andres Rey
Webhook didnt trigger, nothing is running on Travis CI. I'll take a look this weekend.
Looks alright, want to submit a PR to see how the test behave with this change?
Weird, xdebug probably dropped support for 7.0. Can you just commit your code and submit a PR? Travis will run all the tests.
I'm always wary of merging this type of fixes. Adding safe checks around the code is just a patch, where the real problem is hiding somewhere else. The engine should...
Indeed enters into an infinite loop. Will investigate later.
Seems that the div that wraps the images is confusing the parser. I'll take a deeper look at it later this week.
I'm getting the same result with the latest version of readability.js. You might want to submit this issue there as well: https://github.com/mozilla/readability/issues
Seems that your change is breaking the tests. Can you take a look at it? The main problem I see is that the url your change generates has the file...
I was able to reproduce this in the latest development version. I'll take a look at it next weeeknd :)
Seems that it's a problem with the way you parse _elegant_ quotes (these ones: ”) If you check that snippet from what Readability returns, you'll see it's valid HTML: ```...