Andrea Ranzato comments

Results 14 comments of


                                            Andrea Ranzato

`has_role()` does not select columns for imputation in `step_impute_knn()`

Wow, I definitely saw imp_vars(). Unsure why I didn't try that out 😅 I guess it felt so natural to use it without that it should have worked despite what...

Some issues importing spec files with verison 1.9.0 of the seasonal package

Dear @bcmonsell, I am trying with a full length title and I am not seeing any error, at least using "in-line" data. Would it be possible to create a reproducible...

Implement `sum(na.rm = FALSE)`

Actually, "large numbers" are not the problem here, rather `na.rm = TRUE` in `sum()`. Probably needs to be harmonized with dplyr's behaviour. ``` r library(tibble) df1 duckplyr::as_duckplyr_df() |> duckplyr::summarise(amt_tot =...

Implement `sum(na.rm = FALSE)`

@krlmlr, sorry for the follow-up. This latest reprex should make it clear. I wonder whether duckplyr should beahave similarly to what I get from a connection (i.e. throwing a warning)...

webshot2

@moodymudskipper yes please 😃

feat: Add support for `lubridate::month()`

After #658.

feat: Add support for `lubridate::month()`

Right. The contribution guide mentions that. Will add tests, too. Happy to add more functions.

feat: Add support for `lubridate::month()`

Thanks, @krlmlr. I added one test and updated the vignette. Is this good enough? Am I missing something?

feat: Add support for `lubridate::month()`

Thank you, @krlmlr. - Would you prefer additional lubridate helpers in this PR or in a separate one? - I noticed tests were failing. I believe this may be because...

feat: Add support for `lubridate::month()`

Still failing: ``` ── Error ('test-as_duckplyr_df.R:1656:3'): as_duckplyr_df_impl() and mutate(d = month(d)) ── Error in `mutate(., d = month(d))`: Function `month()` not found. Backtrace: ``` Didn't get it running tests locally,...