andrelkin

I attempted to revert 04609a503b2c2301ac87cf25adc97ae7ab9ced6b to manually merge couple of obvious conflicts and build. Still no cigar.. The timeout remains (I did cquery-freshen-index just in case as well).

I also had "wrong-type-argument string" error which turned out to be a bug in `github-review-view-comments-in-code-lines-outdated == t` branch of ` (github-review-place-review-comments)`. I've not fixed the branch yet, still to those...

> Thanks for your work, this is a nice simplification! I left one comment inline for you to take a look at. > At this point the whole stack is...

@charignon, howdy. After a break caused by my load at workplace, I am resuming with this request. I see the PR has not been merged with `master`, perhaps not having...

@charignon, resuming on my Apr 5 target, having time to understand how to make it the right way (git merge is not). Hope that is not interleaves with your generous...

At testing one observation if found. The commit review start function does not pick up ```+(defun github-review-commit-start-internal (commit-alist) + "Start review given commit URL given COMMIT-ALIST." + (deferred:$ + (deferred:parallel...

> What do you mean by does not pick up? When you call `github-review-start` and give a link to a commit like `https://github.com/charignon/github-review/commit/0581a6079ebc1404c873aef133ee66d8bb7217c8` does it not work? Yes. E.g I...

Here is a patch that I sketched to fix the comments delivery, briefly tested. ` [peek_comments.diff.txt](https://github.com/charignon/github-review/files/4847763/peek_comments.diff.txt) `

Salute, @charignon ! I somewhat tested patches of Jul 4th. Now turning to test lc--mvp-review-commit branch. Thanks for the invite :-)!

Does not seem to work correctly in the plain commit case now. E.g when https://github.com/MariaDB/server/commit/9d3742212e1d54a6ceaae87a45ec3428a59d1bd7 is requested the retrieved diff is not from there. I am investigating what is wrong...