Andreea Florescu

Results 26 comments of Andreea Florescu

Verbose output on ARM: ``` Build test executables Coverage found the following executables: [] Running "kcov" "--merge" "--exclude-pattern=/root/.cargo" "--verify" "/kvm-ioctls/target/cov" ``` Verbose output on x86_64: ``` Build test executables Coverage...

@upxe do you have an example of a boot argument that follows the `--bar` pattern you are mentioning in the issue? From [this documentation](https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html) I understand that the kernel interprets...

Great investigation @andreitraistaru! That looks correct and matches my understanding as well. I think with this though minimal changes are required to the Firecracker code to fix the problem: -...

I am much in favour of this approach. Although I do have to say that we will probably not have the time to work on this any time soon. If...

> Does this limit Firecracker to EC2 instances? If so, why such a limitation–is the emulated `CPUID` required for the guest to understand what instructions are available? Firecracker can be...

I think these should be tested with CI, not much you can do with unit tests.

Debug is needed for errors that generate panics (`Error` enum in api server and `Error` enum in vmm). Display is needed for errors that end up at the external user...

@samuelkarp We are using type object on all requests, not just MMDS. The code that parses requests from client into json is generic and the same for all requests. Changing...

One common usecase that we have to consider is `dev/kvm` not having the proper permissions.

@xibz the only idea I have here is to check that the ```--exec-file``` parameter contains the "firecracker" string. As of now we don't have a good way of checking that...