anandsathe67

Results 24 comments of anandsathe67

Using the latest (as of this moment) version of nx (13.4.0), the following patch works. Had to tweak a few more things in addition to @MrPumpking 's changes diff --git...

Changing line 74 of src/executors/build/build.js to `yield Promise.all(normalizedOptions.files.map((file) => copy(file.input, file.output)));` instead of `assets_1.copyAssetFiles ....` and adding an import `const { copy } = require("fs-extra/lib/copy");` fixes this issue

[@simondotm+nx-firebase+0.3.3.patch.txt](https://github.com/simondotm/nx-firebase/files/8496194/%40simondotm%2Bnx-firebase%2B0.3.3.patch.txt) This is a cumulative patch for this issue and #44

@simondotm @BraunreutherA please review

@drmikecrowe Am using 13.10.2 - other than a patch for this plugin and switching over to using the js:tsc executor instead of the package executor, things work ok

> @anandsathe67 -- see https://gist.github.com/drmikecrowe/8bcfc88a0ee29d6c3535e6460c014144 -- with the recent #45, I don't think the patch is needed now. However, I'm still getting problems (yeah, this should have gone on #44,...

> @anandsathe67 can you please share with us how to apply the patch? Do I just drop that txt file somewhere in the node_modules in the project? Or do I...

See PR https://github.com/baumblatt/capacitor-firebase-auth/pull/199 which I just reviewed. Note the link I mentioned in the comment https://harryherskowitz.com/2021/08/23/firebase-capacitor.html This solves https://github.com/firebase/firebase-js-sdk/issues/5019 which you will run into if you are using this plugin...

Just to be safe - I uploaded my changes (which have been tested and used in my app) as a PR https://github.com/baumblatt/capacitor-firebase-auth/pull/204. Changes are pretty much the same as in...