amyangfei comments

Results 31 comments of


                                            amyangfei

Engine should be robust when create worker returns error in executor runtime

Will be solved in https://github.com/pingcap/tiflow/issues/6749

engine: rename the enginepb package name to pb

> @lonng @amyangfei The reason why engine change pkg name from 'pb' to 'enginepb' is : #5555 #5627 > > I think we need to do more work. Yes, I...

engine: rename the enginepb package name to pb

> @amyangfei Why not change the `enginepb.WorkerInfo` to `pb.ExecutorInfo`, > > ``` > message WorkerInfo { > string id = 1; > string executor_id = 2; > bytes status =...

servermaster(engine): implement openapi with grpc-gateway

/run-all-tests

test(engine): handle integration test logs properly

/run-engine-integration-test

test(engine): handle integration test logs properly

/merge

test(engine): handle integration test logs properly

/merge

TiCDC Craft binary protocol document

> @amyangfei Is this PR technically approved? @TomShawn yes

increase DM unit test/integration test code coverage

integration test not stable case - [ ] https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/dm_ghpr_test/detail/dm_ghpr_test/1810/pipeline

make document better

> Does `ignore-checking-items` need to be documented? yep, added in list