Aaron Moore
Aaron Moore
Thats great thanks, I'll take a look at some of the suggestions you mentioned. The fullpage element is inside an iframe, so I need to enable "scrollBar" and "autoScrolling" to...
Looks great, good job @DarioR01 and @mfonofm! There are new theming options introduced in https://github.com/bbc/simorgh/pull/10230 that may be worth trying here, instead of using the imported colours from Psammead. The...
> All good but think ramda types should be installed as a sep PR so it's easier to trace! Just off the back of this, could you remove the `types/ramda`...
Should we disable the `react/prop-types` eslint rule for our `.tsx` files? Shouldn't need it since TS will be doing the type checking for us. E.g, this should be valid:
Explicit options have been added to `helmet` in `src/server/index.jsx`, as this change introduced some breaking changes to the default set of options: https://app.renovatebot.com/package-diff?name=helmet&from=4.6.0&to=5.1.1#d2h-211439: ``` + ### Changed -- 44 |...
Is it worth creating a new `ExperimentContext` solely for experimentation rather than passing the values through `RequestContext`? Just to keep it isolated more than anything.
> > Is it worth creating a new `ExperimentContext` solely for experimentation rather than passing the values through `RequestContext`? Just to keep it isolated more than anything. > > Can...
Couple of comments, but looks good, great job! 👍🏼
Reopening this as the previous attempt to remove the promise exception handler seems to have introduced E2E failures on Test/Live in CodePipeline, see issue #9465. I can't narrow down the...
Closing in favour of https://github.com/bbc/simorgh/pull/11122