Kim Myeongseop
Kim Myeongseop
1. I intended to remove ```p``` wrapper from message slot for following reasons: - Accessibillity concern: Current ```p``` wrapper lacks several wai-aria attributes, such as ```role="alert"```, ```aria-label``` or ```aria-labelledby``` or...
@okhat >I get this multiple times, but I don't quite understand the value proposition here. Considering `setup.py` is classified as legacy in [official pip document](https://pip.pypa.io/en/stable/reference/build-system/setup-py/), so adopting a recommended standard...
@darinkishore lgtm! ~~I'll close this issue as completed.~~
I'll close this issue as soon as the PR in #254 is merged.
I believe the current `FakeListLLM` with `BaseCallbackHandler` can be utilized for the said purpose.
While solution suggested by @Jflick58 works, I think adding official Atlassian Confluence support still remain as a good idea.
@hwchase17 While I agree that old ones should be updated to be retrieval, I think there's a merit of having a retriever-based qa agent; But I will work on `VectorStoreToolkit`...
@hwchas17 I updated the old ones - `create_vectorstore_agent`, `create_vectorstore_router_agent`, `VectorStoreToolkit`, `VectorStoreRouterToolkit`, `VectorStoreQATool`, `VectorStoreQAWithSourcesTool` ` as well. `VectorStoreQATool` and `VectorStoreQAWithSourcesTool` will use `as_retriever()` method based on RetrievalQA.
Since code has changed much, I agree with @baskaryan.