Sherif Abushadi

cleanup punchlist

3

- [ ] inconsistencies between RS and AS initial steps. i would prefer that these are symmetrical / 100% parity https://github.com/near-examples/NFT/blob/master/README.md - [x] remove simulation unless we're committed to it...

first pass at simulation testing for escrow

1

note escrow is not setup yet but this should help

contract compilation fails due to borsh update

4

https://travis-ci.com/github/near/create-near-app/jobs/356517030#L670-L709 ``` Compiling status-message v0.1.0 (/home/travis/build/near/create-near-app/tmp-project/contract) error[E0277]: the trait bound `Welcome: borsh::de::BorshDeserialize` is not satisfied ``` while dependabot is trying to `bump borsh from 0.6.2 to 0.7.0 in github/near/create-near-app/common/contracts/rust` not...

provide a better wallet_auth_key prefix

3

currently wallet uses a user-defined prefix for the key in LocalStorage note: ***undefined_*** wallet_auth_key ``` { "undefined_wallet_auth_key": {"accountId":"sherif-demo.testnet","allKeys":["ed25519:Azqg7VBLGYo8LdiJ4SEzgodg3JXANoJm8jbH1homoVj6"]} } ``` this could be improved with a more friendly default value...

confusing account experience: shell to wallet

1

not sure where to document this exactly, here or `nearprotocol/near-shell` i started by creating a new account through NEAR Shell near create_account sherif3 --masterAccount=sherif and ended up trying to recover...

confusing gas usage on a Tx in NEAR Explorer

10

# subject gas usage i don’t understand: https://explorer.nearprotocol.com/transactions/2tPcYYi6xYzTbHeprZTD6y8siiwxaNVbpGnYudchqa3u  ## Prior conversation question: > _how can `gas_used` be higher than `attached_gas` and still the Tx is successful?_ answer: > _Attached...

The current code for the contract (in `assembly/main.ts`) has 2 similar (redundant) functions: `getBalance` and `balanceOf`. also `collections` is not used. in keeping with the standard interface, including the method...

``` ln: EPERM: operation not permitted, symlink '../contract/build/debug/greeter.wasm' -> 'C:/Users/--redacted-user-name---/Documents/Github/dapp/ near/near-dapp-demo/out/main.wasm' > [email protected] dev:deploy:contract C:\Users\--redacted-user-name---\Documents\Github\dapp\near\near-dapp-demo > near dev-deploy Starting deployment. Account id: dev-1615213642054-1973236, node: https://rpc.testnet.near.org, helper: https://helper.testne t.near.org, file: ./out/main.wasm...

unless i'm misunderstanding something, it seems like `predecessor_account_id` can be easily surfaced into the `context` object exposed by `near-runtime-ts` https://github.com/nearprotocol/near-runtime-ts/blob/4d7247f060deb63bf9aa7a287cb37c28609ccd7e/assembly/runtime_api.ts#L28-L29 but it is not https://github.com/nearprotocol/near-runtime-ts/blob/master/assembly/contract.ts just happened to wonder about...

toString implementation on i32 produces surprising results

10

**steps to recreate** ```js let price = "8157"; // (1) typecasting we use in our tests // https://github.com/nearprotocol/near-runtime-ts/blob/master/tests/assembly/hello/main.ts#L55 let btcPrice: i32 = I32.parseInt(price); logging.log(btcPrice.toString()) // produces 8157