Amey Chaugule
Amey Chaugule
> I think it would be great to add the traversal code and the map approach I mentioned as an example to upstream for future users who want to do...
Taking a second look at implementing this the using a global hashmap with pointers to Arc and solution is somewhat more hacky and error prone and as developers trying to...
@ozankabak would love any pointers. this code is admittedly a quick draft. so we pass in a hashmap and recursivesly traverse the tree. ``` pub struct NodeIdAnnotator { next_id: usize,...
> Just wanted to leave a note to stress that I haven't forgotten about this -- this is on our shortlist to focus on after resolving some urgent issues. thanks...
@ozankabak @alamb taking a look at this again as we are working on snapshotting and UI for Denoramlized. It seems to me that the ideal place to add these is...
> * What would be the default value of id (if `with_node_id` wasn't called)? so was thinking if this isn't set, simply letting it be None in the default. this...
Just cut a PR based on feedback from @alamb
would love to actually get this merged in @xudong963