Andrew McNulty

Results 21 comments of Andrew McNulty

> * I don't see why build.cfg.ninja should be removed, it is used with CMake ninja builds. `build.cfg.ninja` was renamed to `build.cfg.cmake` and its contents were updated so that the...

Thank you for your feedback! I will take another look at this PR and integrate your feedback as soon as possible. It has been a few months since I looked...

@mikkelfj Apologies for not having come back to this, I had forgotten admittedly. My original intention was motivated by a need I had at my previous workplace and in the...

> If meson removed the ability to lexically sort strings it's entirely possible no one would ever notice except for the people who realize they should have used the version_compare...

I've squashed all the CI failure related commits into the original. Apologies for any noise.

> See comments on the linked issue -- please tag #5134 as well. I've squashed together my commits and tagged #5134 in commit message. There's a failure in the Windows...

> Does not work for github purposes, each tagged issue must have its own copy of the word "Fixes" because github is github. Oh well, manually added the cross-linking this...

> There's an interesting question here about what the behavior should be if we warn but continue when cython doesn't support the limited API. I wasn't sure about what the...

> Yes -- it sounds like we should just make it a fatal meson error. The current logic is if the user has specified a `limited_api` kwarg and Meson finds...