Amanj Sherwany comments

Results 16 comments of


                                            Amanj Sherwany

IsInstanceOf Wart doesn't work in cases of placeholder syntax

Yup it's fundamentally the same

`null` in recursive value field

I will create a wart to prevent recursive fields, it should not be doable

Wart for implicit toString in String concatenation and interpoltion

StringPlusAny covers this

Idea: maybe let’s ban `Predef.require` and the likes?

I don't think banning partial functions is a good idea, something as elegant as the following would be banned: ```scala List((1, "one"), (2, "two)).map { case (n, s) => println(s"$n...

Idea: maybe let’s ban `Predef.require` and the likes?

Ah I see. I myself have not activated the wart though, for me it is a bit too strict.

Warts should not skip synthetic trees

Yeah, I will work on this and make sure that I don't break anything. I have a huge code base to run my modifications against

Warts should not skip synthetic trees

I am still struggling in implementing this without introducing other false positives, will update you if I got somewhere

pawn structure & harmonious play

> i understand your idea to add some handcrafted terms for evaluation .. does an engine exist which have "pawn structure PSTs"? The pawn movement / structure eval could be...

False positive-ish: no way to suppress warnings on imports

That should be easy, will try to find time to address it.

Description of `RefinedClasstag` is missing from README.md

I think, one can simply copy the PR description to the README. https://github.com/wartremover/wartremover-contrib/pull/26