Alan Malloy

Results 28 comments of Alan Malloy

I've implemented this in https://github.com/amalloy/dominion/compare/master...library - it's in a separate branch because I don't want to suggest you pull it until it's possible to test it.

Thanks, that's great. It will probably be important to be able to also specify the kingdom cards, so that it's possible to test things like "play Workshop, gaining Feast, then...

On further reflection I think this can probably be handled by just the State monad, with a newtype wrapper around it so that it's impossible for functions to change things...

Hey, thanks. I didn't know Shift-Space scrolled up. That's handy.

Yes, you can pass a naming strategy to the protodef call now which will let you convert from protobuf to keywords and back in whatever manner you like.

It should work to simply modify the `protodef` to use a naming strategy that doesn't change the protobuf names at all: ``` clojure (def Quiz (protodef com.example.Example$Quiz (reify PersistentProtocolBufferMap$Def$NamingStrategy (protoName...

@Raynes Let me know if this doesn't make sense or you need more from me.

Could you be clearer about how you're detecting this size increase? I see you've included adapter code to plug into Kryo, but nothing that specifically reproduces an issue. I also...

@lowasser might have an opinion here - it looks like he originally broke out `SUPPORTS_ITERATOR_REMOVE` from `SUPPORTS_REMOVE`. What you say sounds plausible to me, but I'm not an expert on...