Martin Schuck
Martin Schuck
I have addressed most of your comments. In addition, I noticed that some tests failed with jax on systems with a GPU because the test comparison function for Array API...
@pseudo-rnd-thoughts This is why there is an `env_xp` and a `target_xp`. `env_xp` converts actions to the environment framework, `target_xp` converts them to the framework you want the observations to reside...
The latest changes address some of the concerns with pickle, though I'm not 100% satisfied. `ToArray` now uses its own `__setstate__` and `__getstate__` functions, but this might break `EzPickle` if...
How willing are you to make breaking changes @RedTachyon ? If we make the arguments to `NumpyToTorch` etc. the same as to `ToArray`, there is a pretty straightforward way of...
Might be, yes. Or `ArrayConversion`/`ArrayTransfer`. By the way, it seems like `jax 0.6` broke the Jax wrappers. Once the pickling issues have been resolved, we might want to look into...
I have rebased my PR to the latest changes in gymnasium and renamed the wrapper and conversion function. The remaining open questions, including concerns raised from @RedTachyon's review, are: -...
I now fixed all the remaining tests, didn't see that parts of the pipeline were failing. What do you think @pseudo-rnd-thoughts @RedTachyon ?
Regarding the 3.10 vs 3.9 issue: The `array_conversion` wrappers have a hard requirement on Python 3.10 and above, so we would need to raise an error if someone is trying...
The last commit simplifies the logic of `module_namespace` and `module_name_to_namespace` and avoids hard-coding the names of supported frameworks. This means that new frameworks will become available as soon as they...
> Thanks for your interest @Jammf. > For me, I can understanding the rationale for dropping 3.9, I'm personally just worried about dropping both 3.8 and 3.9 at the same...