Adeel Mujahid
Adeel Mujahid
> which one, by the way? I know there's at least two of them Potentially both can be simultaneously supported via feature detection [[example](https://github.com/dotnet/coreclr/blob/5fc2313f1bc4ffac033f38b2162175c958cfdf3f/src/pal/src/configure.cmake#L994-L1025)]. LLVM one has some limitations like...
I attached debugger and it seems like error is coming from upstream dependency https://github.com/nanopb/nanopb/blob/6a6903b/pb_encode.c#L336 (probably when it hits `\0`). @Snaipe, I even get access violation with: ```c++ #include "./includes/criterion/criterion.h" int...
> not main() Ops, forgot about build-in entry point. 😀 I tested with fix/216 on win10 and it seems to not crashing. However, the stdout is printing `a` instead of...
> only the runner needs to call that This is true, though in `params.c`, I had to at least delete / ifdef out the `setlocale(LC_ALL, "");` line to get the...
It is painful in a way that Windows console has separate APIs for wide characters; WriteConsoleW etc. I think instead of `SetConsoleOutputCP`, using [`_setmode`](https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setmode) (file translation mode) on `stderr` for...
> Do you have any idea why setlocale(LC_ALL, ""); wouldn't be working here? I would expect the locale needs to be at least initialized before setting the console codepage. Certainly,...
Could we update https://github.com/Snaipe/Criterion/blob/ccf5d1dcd66c81d32536b043a4df608a72c7f6ca/appveyor.yml#L3 to `Visual Studio 2017` to check if it makes any difference in vsnprintf behavior? Seems like they have made some improvements around C99/C11 to make backend...
> Do we need to update `$(NewtonsoftJsonVersion)` too? Updated in https://github.com/dotnet/runtime/pull/71402. The only file I had to revert is `NetCoreServer.csproj` (in 3a1fd4d) which this PR is updating. It looks like...
@MihaZupan, it needs https://github.com/dotnet/arcade/pull/9962 (and probably an update from xharness running the updated arcade)
Great. I suppose we are waiting for https://github.com/dotnet/runtime/pull/72934 and https://github.com/dotnet/runtime/pull/73517.