Alexi

Results 10 comments of Alexi

I am currently looking into this and will ask to be assigned once I have an idea for a fix.

Ah ok, and so not handling orientation is a different and bigger issue to fix. I'll look into something else, thanks!

What actions would showing the next and previous card map to? I couldn't find any that seemed appropriate.

> Yes, ideally same gestures work without having to define them > > but `go to next/previous card without showing answer` is an action exclusive of the preview window and...

After looking more at `ViewerCommand`, it does seem like this class is intended to be used only with `Reviewer`: all of the MapableBindings are connected to it. I feel like...

My solution that seems to work is as follows: - keep all gesture actions in `ViewerCommand.values()` - add specific gestures for each `AbstractFlashcardViewer` (just `Reviewer` and `Previewer` in this case)...

There is also an issue where pressing a key in `Previewer` causes the screen to darken. This is an issue in `main` as well.

This PR still needs translations. It is my understanding that now that I've added a string resource, it will go out for translation, and I don't have to do anything...

Sweet! Didn't expect everything to be 100% the first time, glad to hear this approach is acceptable. I'll get those changes in as soon as I can.

Not sure what's going on with ubuntu-latest tests, I ran them locally with no errors.