Sasha Sorokin

icon indicating an email [email protected]

icon company Akvelon icon location Armenia icon location I'm a software developer in Akvelon and (used to be) an Apache Cordova committer. I also play and create video games as a hobby.

Results 20 comments of Sasha Sorokin

CB-12873: Add customization options for caputre button, resizing of v…

cordova-qa: rerun tests

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

@alpesh12 from what I see, `cd tests/ios && npm install && npm test` has failed with the following error: ``` /Users/travis/build/apache/cordova-plugin-camera/src/ios/CDVCamera.m:373:36: error: variable is not assignable (missing __block type specifier)...

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

All the following errors are because of the failed build. Not sure why paramedic continues the test run after a build failure though...

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

There's still one test failure, is it expected? ``` Test Case '-[CameraTest testProcessImage]' started. 2018-02-28 14:10:55.751 xctest[2330:8469] -[CDVCamera processImage:info:options:]: unrecognized selector sent to instance 0x7976c770 /Users/travis/build/apache/cordova-plugin-camera/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m:481: error: -[CameraTest testProcessImage] :...

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

I've tried restarting tests and it's still there

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

I see. Well, If you've changed the function signature, I guess you should also change the test to pass that new argument to it.

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

This is the line that is failing: https://github.com/apache/cordova-plugin-camera/blob/master/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m#L481 Hope that helps :)

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

I'm not sure what you mean. it is failed here: https://travis-ci.org/apache/cordova-plugin-camera/jobs/334579377#L1781

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415)

Well I guess we have to wait until he reviews it then. I don't have enough expertise in iOS to merge it anyway :)

False semicolon-termination error

Proposed fix is to visit all children of `CREATE FUNCTION` statement and find `RETURN` statement. Then just disable the rule for all `SELECT` statements inside the `RETURN` statement.