alon gouldman

Results 5 comments of alon gouldman

@chayim @dvora-h can i take this issue and fix it all over the code? I'm happy to 😊 Here is explanation about why %-string is better: https://blog.pilosus.org/posts/2020/01/24/python-f-strings-in-logging/

@chayim I'm happy to demonstrate, do you mean in general demonstration, or in redis's use case? If you mean in redis, do you have a set of performance tests which...

Hi @chayim This is the test I run: ``` import logging import timeit def short_f_string(): name = "world" logging.debug(f"hello {name}") def long_f_string(): name = """ looooooooooooooooooooooooooooooonnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnngggggggggggggggggg massage wow this is...

do you have any idea why this PR failed?

is this still open? can I implement what @ambv suggested?