Ali McMaster comments

Results 9 comments of


                                            Ali McMaster

Add error handling, fix broken unit tests

Firstly thanks for a well defined PR and for adding the test dependency, I missed this here #207. Changes generally look good to me at a first glance. One comment...

Add support for more code formatters

@OrkoHunter - what would it take to support black? Mind outlining what would be involved? I might be interested in working on this. Thanks, Ali

bpo-33092: Better bytecodes for f-strings

Any update on this @taleinat suggested sharing benchmarks here https://bugs.python.org/issue33092. Otherwise due to lack of activity I think we can close this.

Update quickstart.rst

[syrusakbary](https://github.com/syrusakbary) - please could someone take a look at merging this.

improve RelationshipDefinition constructor performance

Thanks for the contribution :) Is this code tested somewhere in unit test in this project? Do we have code coverage here?

Update match.py

Thanks for the contribution please could you write a test case to help demonstrate the issue?

VOTE: Core Team Vote on Keeping/Removing pyarrow warning

Option 1

BLD: Split out tests into pandas_tests package

Hey! Thinks this is a decent idea. How much does this decrease the dist size by? Would be good to know that before merging this as that's the main benefit...

Governance proposal: Steering Committee and Teams

Thanks for all the work on this @Dr-Irv - looks great to me.