Martin Algesten comments

Results 465 comments of


                                            Martin Algesten

Use more specific OAuth scope

What would be the advantage of using a more narrow scope?

Make persistence work for other use cases

@kpcyrd thanks! > I had trouble recreating this with the persist trait. … (the folders in certs/ are atomically created with an increasing counter and I can't pass the path...

Make email optional

Thanks I understand now. I think we can make this work, but maybe by not modifying the current surface API. Downloading a cert without persistence maybe is solvable using the...

Make email optional

Since you ultimately want to save keys and certificates, wouldn't it just be easier to implement the `Persist` trait?

Make email optional

@kpcyrd Since it seems you do want to persist the keys/certificates, can we maybe explore why the `Persist` trait isn't working for you in #18?

Use tokio only

This was released in 0.8.0

Document new patch syntax

I'll fix :)

Document new patch syntax

Well. At one point I had nice documentation for the patch syntax. I always intended to rewrite it with the new syntax. Even if the diffing part of this project...

Document new patch syntax

here it is/was https://github.com/algesten/jsondiff/blob/4ed22b4300d1e2f4db7fc148ad2a9afe34ba0766/README.md

Javascript version?

Hi there! Yes it would be awesome and it is on my list of places I'd like to take this library. My thought is to just make a straight port...