Sasha Alex Romanenko
Sasha Alex Romanenko
Identifier quoting issues are often related to https://github.com/laminas/laminas-db/issues/77 (original discussion at https://github.com/zendframework/zend-db/pull/233) and maybe https://github.com/zendframework/zend-db/pull/232. Maybe something in there could give a useful hint to fix in own fork fix....
Yes, you can see example in my MSSQL PR at https://github.com/zendframework/zend-db/pull/231/files and more specifically https://github.com/zendframework/zend-db/pull/231/files#diff-1c04a65ef544d7ab52700dcd9818209e Generally speaking: 1. Extend existing decorator into your project, and use that decorator (or modify...
This is not a first time I ran into problem of constraints and foreign keys used interchangeably in syntax generation. @ezimuel Should version 3 or maybe even next 2.x consider...
Your idea looks fine for temporary work around. Would vote against including something like that in library, because optional parameters create unmaintainable logical path branches that future contributors often forget...
Its the same problem. There are many bugs in PostgreSQL adapter as primary example from top of my head because of inconsistency of optional parameter handling few function calls in....
More specifically, $constraint = new Constraint(); $fk = new ForeignKey(); $table->dropConstraint($constraint); // should work $table->dropConstraint($fk); // also would work.
PR looks much nicer without that string property. >That seems logical to me if for example you want to iterate over an existing structure you've just retrieved by analyzing the...
I am trying to go through available abstraction utilities (data types, constraint types etc.) to check they work with PostgreSQL and update the newly created decorator as I find them....
@ezimuel I was waiting on some assistance about difficult architecture decisions outlined in last comment at https://github.com/zendframework/zend-db/issues/186 and a potential discrepancy with another PR linked in todo list. I got...
@froschdesign I will put the effort in! Thank you! It'll be challenging to rethink something this complicated a year later so I will take some days to catch up to...