Alex Gokhale

Results 17 comments of Alex Gokhale

In regards to how the function would work, I envisaged it peeking the limit, and providing both a count and time as paramters would be ideal. It shouldn't affect the...

> Perhaps it's our documentation that's unclear - if you do 5 per 5 minutes here you will effectively get a token every minute, rather than 5 every 5 minutes....

A token bucket system where the refill rate can be entirely customised - for example you could create a new limiter with `NewLimiter(5, 5 * time.Minute)` and this would refill...

> What use-case requires this kind of rate-limiting? The requirement came from the desire to limit file uploads to a strict limit per 5-minute period. With slack/burst they'd be able...

Sorry for the delay in replying to this. I think you're right that the algorithm can be configured outside of lazygit and will stick around, which is probably the correct...

This would be super useful -- it would be great to know whether the recommended way forward with this is to just create a custom multiline parser, or can we...

@srebhan any chance you could take a look at this and the associated pull request when you have a sec (or point me towards someone else who could)? Happy to...

Thanks for the review! I was away last week but will actions your comments as soon as possible :)

@srebhan Hey -- just wanted to check in before I make the last changes (to switch to Precision and then re-organise the file): The use case that prompted this feature...

Also one clarification on the meaning of positive/negative numbers on precision – might it make more sense to have a positive number meaning to the right of the decimal separator...