Alexey Romanov
Alexey Romanov
### Summary Tests in `node_package/tests/RSCClientRoot.test.jsx` were calling `act` without `await`, leading to these warnings: > You called act(async () => ...) without await. This could lead to unexpected testing behaviour,...
### Summary _Remove this paragraph and provide a general description of the code changes in your pull request... were there any bugs you had fixed? If so, mention them. If...
Posting under this template since the description includes "missing documentation" ### What you did: Read https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md. ### What happened: https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md ends with the ["`wrapper` Props" header](https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md#wrapper-props). Is it supposed to...
### Summary Extracted from #1868 because it adds `spec/performance/bench.rb` and the default Rubocop config doesn't fit our repo. ### Pull Request checklist - [ ] ~Add/update test to cover these...
### Summary The Pro dummy app was looking for a non-existent file in its `precompile_hook`. ### Pull Request checklist - ~[ ] Add/update test to cover these changes~ - ~[...
### Summary #2121 missed some changes in scripts and docs. Fixes #2188. ### Pull Request checklist - [ ] ~Add/update test to cover these changes~ - [x] Update documentation -...
Now that we use Yarn workspaces for RORP packages, we can also use them for the dummy apps and remove Yalc. This will simplify scripts, CI, and make the repo...
### Summary Add performance tests. Fixes #1777. ### Pull Request checklist - ~[ ] Add/update test to cover these changes~ - [ ] Update documentation - [ ] Update CHANGELOG...
E.g. for React versions to be stated only once. See https://pnpm.io/catalogs. Note `convert` script will need to be updated as well.
It only seems to do something when using `yarn` https://github.com/shakacode/react_on_rails/blob/97fde8431e83631399dfb1df1f673b5c468dfd2a/.github/actions/setup-node-with-retry/action.yml#L43 but after #2121 we don't anymore, so it can be safely replaced with `setup-node`. Also, it's apparently based on https://github.com/shakacode/react_on_rails/blob/97fde8431e83631399dfb1df1f673b5c468dfd2a/analysis/v8-crash-retry-solution.md?plain=1#L14-L19...