Alex Pakhunov comments

Results 5 comments of


                                            Alex Pakhunov

gh-96859: [argparse] Avoid O(N^2) behavior while consuming optionals

> Tests / Windows (x86) (pull_request) Failing after 31m > https://github.com/python/cpython/actions/runs/3091293898/jobs/5001192381 This does not seem related to the changes on the PR. Also the latest commit only touched comments.

gh-96859: [argparse] Avoid O(N^2) behavior while consuming optionals

A friendly ping to bring some attention to this PR. @rhettinger, would you be the best person to do a core review? You listed as the maintainer of argparse.py at...

gh-96859: [argparse] Avoid O(N^2) behavior while consuming optionals

Thanks for your feedback, @hpaulj. The change is indeed fixes a performance issue and attempts to not modify the existing behavior in any way. The test_argparse.py suite looks pretty comprehensive...

gh-96859: [argparse] Avoid O(N^2) behavior while consuming optionals

> You might consider something similar with a parse_faster_args Hm, this is an interesting suggestion... `_parse_known_args()` is 200+ lines long. It would not be wise just clone it and apply...

gh-96859: [argparse] Avoid O(N^2) behavior while consuming optionals

Closing this PR due to lack of interest.