Alexander van Eck

Results 41 comments of Alexander van Eck

TODO: Add SLURM REST API to ci/slurm and remove mocking from test_end_to_end. We can use the slurm cluster instead. (cc @jacobtomlinson I think this is a better idea)

> Given that you've already written the mocked test there's probably little harm in leaving it in, but adding a CI test would be good. > > (Also don't worry...

@lesteve Would you have any tips on how I can update the ci/slurm integration test docker setup and have it be used during integration testing of slurm? For this PR...

> Please stop force pushing 😂. I can't see what changes you are making. > > ![image](https://user-images.githubusercontent.com/1610850/124931381-114cdc80-dffa-11eb-9671-84cea7296f96.png) I'll try my absolute best. 😬 it's part of my normal workflow to...

@jacobtomlinson I got it to work with Unix sockets as authentication. Slurm does not accept unauthenticated requests. Let me know what you think of this implementation. Something inside Slurm is...

I've managed to also add the JWT HTTP configuration - however the integration tests fail. Given that the posted payload is correct it leads me to believe that slurmrestd doesn't...

> I've managed to also add the JWT HTTP configuration - however the integration tests fail. Given that the posted payload is correct it leads me to believe that slurmrestd...

@jacobtomlinson @lesteve this is now ready for a good review, all the features explained in the issue are in. Please let me know your thoughts 🙇 your thoughts help immensely.

I found a bit of a snag working with aiohttp. Due to SLURM responses sometimes (most of the time?) not being parsable the http-parser library fails on reading the response....

Very much! I'm only waiting on the infrastructure that I have access to to enable the SLURM REST API, so I can test it. Would you have time for a...