Makhonin Alexey
Makhonin Alexey
/assign @rikatz
HI! This is my vision on this feature and and if such implementation, in your opinion, is incorrect, I will be happy to redo it :)
Sorry, I can't understand, why test are not passing (can't figure out where to change TestGetBackendServers in controller_test.go). Can someone help me? ```bash --- FAIL: TestGetBackendServers (1.10s) panic: runtime error:...
Okey, I'll try to do my best :)
Hi! I found why metric collector is nil. this is because in test `TestGetBackendServers` it calls[ `newDynamicNginxController`](https://github.com/kubernetes/ingress-nginx/blob/main/internal/ingress/controller/controller_test.go#L2346) function, which returns [`NGINXController`](https://github.com/kubernetes/ingress-nginx/blob/main/internal/ingress/controller/controller_test.go#L2476-L2480) without metric collector defined. Then in test it calls...
@rikatz @iamNoah1 Could you take a look please? ^
@rikatz I've rebased my branch on main, but tests continue to fail. IMHO errors aren't connected with these feature
@rikatz @iamNoah1 Hello! Any updates here? I've rebased my branch on main :upside_down_face: