Amit Levy

Results 207 comments of Amit Levy

Thanks @mcy, this is excellent!

> Any thoughts on try_trait rust-lang/rust#42327? That proved to be very useful in #1480. @bradjc I _believe_ this has a very high chance of becoming stable in the not far...

RE: debug statements, one "trivial" way to strip code down by a lot is to remove modify the `panic` handler for a board with one that doesn't output any formatted...

At least in the SPI case, this is a platform (i.e. board) specific set of configurations: whether a particular HW SPI should be in slave/master mode and the pin polarities...

OK, given that I think there is rough consensus that removing `initialize` from the existing (data-path) HILs, I think it's time to move forward to proposed code changes. E.g. the...

> E.g., suppose that the operation is performed by a separate chip over a bus. E.g., an external encryption accelerator, a GPIO MUX, etc. Maybe there are other examples of...

I agree with (2) completely. I could be missing something, but I don't believe there is a reason for `initialize` to be part of the ADC HIL. I also agree...

> Is there something we can use that would serve the same purpose as the Frequency trait for time? E.g. a trait that who's implementations specified the voltage range used:...

> A potential issue here, is that this would require upping the sample size to 32 bits (giving a possible range of 0 to 4000 volts in units microvolts). This...

Ugh... I (increasingly) think we should have a protocol on top of UART that lets tockloader and tock distinguish which process input and output is related to. I.e., I should...