Alejandro Santiago
Alejandro Santiago
I think this would benefit from #1799 . Where the `Navigator` would be an `InheritedComponent`. Similar to how Flutter deals with navigation.
> I believe we all agree that, by itself, and not taking other factors into account, the name change gameRef -> game is good. There is a difference in opinion...
It is very nice that this change will get in! Great news 🔥💙 Thanks @st-pasha for working on it!
What's the status of this PR? This is very useful 👀
> None of the linked PRs would have been caught by a spellchecker though, not even the tot he one. I wonder if there are grammar checkers we can use....
(cc: @renancaraujo @felangel @erickzanardo @wolfenrain )
@st-pasha the purpose of the above is to guarantee O(1) search with a Flutter like API. I believe, `findParent` fails to do so, since it relies on `ancestors`. Which can...
> https://github.com/flame-engine/flame/pull/1799#pullrequestreview-1041056284 Thanks @erickzanardo for joining. I agree some renaming needs to occur. I've renamed the method to `.read` I think it is less verbose and descriptive. > About bundling...
Thanks @erickzanardo! Haha, funny enough I edited and copied the wrong sample. I will update it as soon as I get back to the office. Thanks for the feedback once...
I'm going on vacation so this PR will have limited activity from me up to around the 10th of August.