Albert comments

Results 77 comments of


                                            Albert

Using ring buffer for LIFO

It's for `for (int i = 0...`. For two compilers listed in travis config file, `gcc-4.8` defaults to sth below c99, even though it supports c11 and gnu11.

stack item FIFO or LIFO to minimise page miss

The code https://github.com/sustrik/libmill/blob/master/stack.c#L169 calls "push_back", which places item in the end, doesn't it?

stack item FIFO or LIFO to minimise page miss

You meat this one: https://github.com/sustrik/libmill/blob/master/stack.c#L178? Since it's LIFO, could we do sth like "pop_back" to free the last in the slist?

stack item FIFO or LIFO to minimise page miss

The stack that needs to be deleted should be the last one, if LIFO is respected. Had a quick look at slist, it seems that it doesn't support implementing pop_back...

stack item FIFO or LIFO to minimise page miss

Further investigation convinced me that ring buffer is a simple data structure for LIFO in this case.

Using profile files with -p option requires specifying full paths

I was bitten by this as well.

Using profile files with -p option requires specifying full paths

It's not a serious problem, but it's good if it could be fixed. Installing/Updating TexLive has always been a pain, but finding your repo made my day. Thank you very...

8282729: Serial: Move BOT implementation to collector specific directory

It's a bit surprising to see changes to other collectors in a commit titled "Serial: ...". I guess that's what you meant by "Move required fixing up some missing header...

8282729: Serial: Move BOT implementation to collector specific directory

/sponsor

8290376: G1: Refactor G1MMUTracker::when_sec

Thanks for the review. /integrate