Alexis La Goutte

Results 298 comments of Alexis La Goutte

Hi, You need to add to have 2 workflows and use on: [pull_request] for make the difference

> It would be great if this could edit the last comment instead of creating new ones for each push. i think it is more complicated... because need to found...

Hi Mark, Thanks for quick return! i will try to look how to update...

Search/march is fixed on #58 and #62 and it will be available on next release

Hi @hlroudjehane thanks for feedback ! I make a quick look of geography address and it will be easy to add ! (need to add a new [parameter](https://github.com/FortiPower/PowerFGT/blob/master/PowerFGT/Public/cmdb/firewall/address.ps1#L93) like -country...

> It looks like the change should be made in this file/location correct? Yes !

after a very quick look a small PR for add #191 some example : ```powershell Add-FGTFirewallAddress -Name FGT-Country-FR -country FR name : FGT-Country-FR q_origin_key : FGT-Country-FR uuid : 33cf29c8-f7e3-51ec-6987-6871166d6ba9 type...

> I updated the 12 lines of code highlighted in address.ps1 to no resolve unfortunately. Is there another file that needs updating? do you reforce the import after modified the...

> Yes in the screenshot I sent you I ran an import. It doesn’t seem to recognize the new parameters added as they don’t auto show while type. there is...